MWPW-146962 [milo] Text link behaving like button in FAQ section #2530
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2530 +/- ##
==========================================
+ Coverage 95.83% 95.84% +0.01%
==========================================
Files 176 176
Lines 46122 46122
==========================================
+ Hits 44199 44204 +5
+ Misses 1923 1918 -5 ☔ View full report in Codecov by Sentry. |
|
Reminder to set the |
afmicka
added
run-nala
|
Skipped merging 2530: MWPW-146962 [milo] Text link behaving like button in FAQ section due to failing checks |
3 similar comments
|
Skipped merging 2530: MWPW-146962 [milo] Text link behaving like button in FAQ section due to failing checks |
|
Skipped merging 2530: MWPW-146962 [milo] Text link behaving like button in FAQ section due to failing checks |
|
Skipped merging 2530: MWPW-146962 [milo] Text link behaving like button in FAQ section due to failing checks |
|
@bozojovicic - NALA tests are failing for this PR, thus it will not get merged to Stage. You can try to rebase your branch with the current |
|
Skipped merging 2530: MWPW-146962 [milo] Text link behaving like button in FAQ section due to failing checks |
|
@overmyheadandbody @skumar09 @Dli3 the Nala failures are not related to the changes in this PR but are blocking it from being merged. Table tests are failing due to the updated classes in chrome for the highlight heading, the daily run is failing with the same error. I guess the tests need an update. Could you please check? HowTo tests are failing because of the expected class for the image. Sometime on forks, it is resolved as 'how-to-image' instead of expected 'how-to-media'. Not sure how it comes to that, but have seen it before. Could you please confirm here and unblock this PR (and similar ones) for merging? |
|
Skipped merging 2530: MWPW-146962 [milo] Text link behaving like button in FAQ section due to failing checks |
* stage: Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) (adobecom#2554) MWPW-149124 Improve Focus Page for Performance Improvement Tiger Team (adobecom#2391) Correctly send the created PR slacks (adobecom#2566) MWPW-153167: caas-config change to enable hiding date detail information (adobecom#2553) MWPW-152016 - Localization target preview for transcreation (adobecom#2564) Relax CORS restrictions for module imports (adobecom#2549) MWPW-153600 [PEP] loader bar on PEP prompt is seen loaded Left to right in RTL locale (adobecom#2548) MWPW-146962 [milo] Text link behaving like button in FAQ section (adobecom#2530) MWPW-152280 MEP: Only preload fragments that are in the 1st section (adobecom#2525) MWPW-152697 Fix Marketo mobile horizontal scroll (adobecom#2514) MWPW-151513: Search results vanished when user clicks on Marquee CTA:Start free trail (adobecom#2406) MWPW-154013 PEP prompt redirection is broken in stage after the PEP dismissal PR merge (adobecom#2547) MWPW-153962: Introduce maslibs query parameter (adobecom#2544) Central georouting support (adobecom#2531) [MWPW-152278] Avoid empty CSS requests (adobecom#2524) MWPW-152918 Fix Marketo button font (adobecom#2513) # Conflicts: # libs/deps/merch-card.js
When checkout URL contains
#_tclit should be transformed to ordinary HTML link and not to CTA. At the moment some not desirable styles are applied to that link e.g.width:100%;text-decoration:noneetc. which I fixed with this change.TCL is an acronym for Text Checkout Link.
BEFORE :
AFTER :
Resolves: MWPW-146962
Test URLs: